Fix: the json_last_error will not reset when using JSON_THROW_ON_ERROR flag

lib/Exceptions/JsonException.php

@@ -9,4 +9,9 @@ public static function createFromPhpError(): self
     {
         return new self(\json_last_error_msg(), \json_last_error());
     }
+
+    public static function createFromJsonException(\JsonException $e): self
+    {
+        return new self($e->getMessage(), $e->getCode());
+    }
 }

lib/special_cases.php

@@ -35,9 +35,13 @@
  */
 function json_decode(string $json, bool $assoc = false, int $depth = 512, int $flags = 0): mixed
 {
-    $data = \json_decode($json, $assoc, $depth, $flags);
-    if (JSON_ERROR_NONE !== json_last_error()) {
-        throw JsonException::createFromPhpError();
+    try {
+        $data = \json_decode($json, $assoc, $depth, $flags);
+        if (JSON_ERROR_NONE !== json_last_error() && !($flags && JSON_THROW_ON_ERROR)) {
+            throw JsonException::createFromPhpError();
+        }
+    } catch (\JsonException $e) {
+        throw JsonException::createFromJsonException($e);
     }
     return $data;
 }

tests/JsonDecodeTest.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+use PHPUnit\Framework\TestCase;
+
+final class JsonDecodeTest extends TestCase
+{
+    public function testJsonDecode()
+    {
+        // assert valid json
+        $this->assertSame(
+            [],
+            \Safe\json_decode("[]"),
+        );
+    }
+
+    public function testInvalidJsonDecode()
+    {
+        // create json error
+        \json_decode("\00 invalid json");
+        $this->assertGreaterThan(0, json_last_error());
+
+        $this->expectException(\Safe\Exceptions\JsonException::class);
+        \Safe\json_decode("\00 invalid json");
+
+    }
+
+    public function testJsonDecodeWithJsonThrowOnErrorFlag()
+    {
+        // create json error
+        \json_decode("\00 invalid json");
+        $this->assertGreaterThan(0, json_last_error());
+
+        // assert valid json
+        $this->assertSame(
+            [],
+            \Safe\json_decode("[]", true, 512, JSON_THROW_ON_ERROR),
+        );
+    }
+
+    public function testInvalidJsonDecodeWithJsonThrowOnErrorFlag()
+    {
+        // create json error
+        \json_decode("\00 invalid json");
+        $this->assertGreaterThan(0, json_last_error());
+
+        $this->expectException(\Safe\Exceptions\JsonException::class);
+        \Safe\json_decode("\00 invalid json", true, 512, JSON_THROW_ON_ERROR);
+    }
+}