Add safe inet_pton #428
Closed
Add safe inet_pton #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Dec 3, 2024
| * @return string Returns the in_addr representation of the given ip, | ||
| * @throws NetworkException | ||
| */ | ||
| function inet_pton(string $ip): string |
There was a problem hiding this comment.
do we know why we need a special case here?
There was a problem hiding this comment.
"returns false on error" is calculated by a bunch of regexes matching against the human-readable text of the descriptions D:
#498 adds this case into the regex rather than manually adding a special case
|
@simPod thanks for taking the time you put into it and making us aware of the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #270
(is not generated from docs)