Update CI/CD workflows #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Splitting shish/safe into smaller parts for easier review) This reworks the CI/CD workflow into smaller parts which run as a tree, so that a failure in one part doesn't block testing in a different unrelated part. Workflows will currently fail because of all sorts of brokenness in the code itself, but when the rest of the merge is complete, it should pass. Also note that this tests PHP 8.1-8.4, even though shish/safe only tests 8.2-8.4 -- this is leaving room for somebody to implement php8.1 (which I couldn't figure out how to do), but if the other maintainers can't figure out php8.1 either, we can make an intentional decision to drop that later.
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Splitting shish/safe into smaller parts for easier review)
This reworks the CI/CD workflow into smaller parts which run as a tree, so that a failure in one part doesn't block testing in a different unrelated part. Workflows will currently fail because of all sorts of brokenness in the code itself, but when the rest of the merge is complete, it should pass.
Also note that this tests PHP 8.1-8.4, even though shish/safe only tests 8.2-8.4 -- this is leaving room for somebody to implement php8.1 (which I couldn't figure out how to do), but if the other maintainers can't figure out php8.1 either, we can make an intentional decision to drop that later.