Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force generator to use PHP 8.1.x #476

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Force generator to use PHP 8.1.x #476

merged 1 commit into from
Nov 29, 2024

Conversation

staabm
Copy link
Collaborator

@staabm staabm commented Nov 28, 2024

to improve DX, as before this PR the generator assumed composer would be run using a PHP 8.1 CLI.

lets define a platform version instead, so it no longer matters which PHP CLI version the developer is using to run composer

@staabm
Copy link
Collaborator Author

staabm commented Nov 28, 2024

//cc @shish @OskarStark

@OskarStark OskarStark merged commit d43727a into master Nov 29, 2024
7 of 12 checks passed
@OskarStark
Copy link
Collaborator

Thanks

@OskarStark OskarStark deleted the gen81 branch November 29, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants