Merge pull request #206 from thecodingmachine/fix/oracle-identifier-t…

…oo-long Oracle: Fix `ORA-00972: identifier is too long` (30 char limit)
thecodingmachine · Jun 30, 2020 · 9f9dac2 · 9f9dac2
2 parents 07360b6 + 53568b6
commit 9f9dac2
Show file tree

Hide file tree

Showing 6 changed files with 505 additions and 117 deletions.
diff --git a/composer.json b/composer.json
@@ -19,7 +19,7 @@
     ],
     "require" : {
         "php" : ">=7.1",
-        "mouf/magic-query" : "^1.3.0",
+        "mouf/magic-query" : "^1.4",
         "mouf/schema-analyzer": "^1.1.4",
         "doctrine/dbal": "^2.9.2",
         "psr/log": "~1.0",
@@ -32,7 +32,7 @@
         "mouf/utils.log.psr.multi-logger": "^1.0",
         "symfony/filesystem": "^2.7 || ^3 || ^4 || ^5",
         "ramsey/uuid": "^3.7",
-        "doctrine/annotations": "^1.6",
+        "doctrine/annotations": "^1.10",
         "zendframework/zend-code": "^3.4",
         "psr/container": "^1",
         "ext-PDO": "*",
@@ -45,7 +45,7 @@
         "phpunit/phpunit": "^7.4.4 || ^8.0.0",
         "php-coveralls/php-coveralls": "^2.1",
         "wa72/simplelogger" : "^1.0",
-        "friendsofphp/php-cs-fixer": "^2.15.1",
+        "friendsofphp/php-cs-fixer": "^2.16",
         "symfony/process": "^3 || ^4 || ^5",
         "thecodingmachine/tdbm-fluid-schema-builder": "^1.0.0",
         "phpstan/phpstan": "^0.11.5",

diff --git a/src/QueryFactory/AbstractQueryFactory.php b/src/QueryFactory/AbstractQueryFactory.php
@@ -165,21 +165,35 @@ protected function getColumnsList(string $mainTable, array $additionalTablesFetc
         foreach ($allFetchedTables as $table) {
             foreach ($this->schema->getTable($table)->getColumns() as $column) {
                 $columnName = $column->getName();
-                $columnDescList[$table.'____'.$columnName] = [
-                    'as' => $table.'____'.$columnName,
+                $alias = self::getColumnAlias($table, $columnName);
+                $columnDescList[$alias] = [
+                    'as' => $alias,
                     'table' => $table,
                     'column' => $columnName,
                     'type' => $column->getType(),
                     'tableGroup' => $tableGroups[$table],
                 ];
-                $columnsList[] = $mysqlPlatform->quoteIdentifier($table).'.'.$mysqlPlatform->quoteIdentifier($columnName).' as '.
-                    $connection->quoteIdentifier($table.'____'.$columnName);
+                $columnsList[] = sprintf(
+                    '%s.%s as %s',
+                    $mysqlPlatform->quoteIdentifier($table),
+                    $mysqlPlatform->quoteIdentifier($columnName),
+                    $connection->quoteIdentifier($alias)
+                );
             }
         }
 
         return [$columnDescList, $columnsList, $reconstructedOrderBy];
     }
 
+    public static function getColumnAlias(string $tableName, string $columnName): string
+    {
+        $alias = $tableName.'____'.$columnName;
+        if (strlen($alias) <= 30) { // Older oracle version had a limit of 30 characters for identifiers
+            return $alias;
+        }
+        return substr($columnName, 0, 20) . crc32($tableName.'____'.$columnName);
+    }
+
     abstract protected function compute(): void;
 
     /**

diff --git a/src/QueryFactory/FindObjectsFromRawSqlQueryFactory.php b/src/QueryFactory/FindObjectsFromRawSqlQueryFactory.php
@@ -211,7 +211,7 @@ private function formatSelect(array $baseSelect): array
             $pkColumns = $table->getPrimaryKeyColumns();
             foreach ($table->getColumns() as $column) {
                 $columnName = $column->getName();
-                $alias = "{$tableName}____{$columnName}";
+                $alias = AbstractQueryFactory::getColumnAlias($tableName, $columnName);
                 $astColumn = [
                     'expr_type' => 'colref',
                     'base_expr' => $connection->quoteIdentifier($tableName) . '.' . $connection->quoteIdentifier($columnName),

diff --git a/src/QueryFactory/QueryFactory.php b/src/QueryFactory/QueryFactory.php
@@ -31,7 +31,7 @@ public function getMagicSql() : string;
     public function getMagicSqlCount() : string;
 
     /**
-     * @return mixed[][] An array of column descriptors. The key is in the form "$tableName____$columnName". Value is an array with those keys: as, table, colum, type, tableGroup
+     * @return mixed[][] An array of column descriptors. The key might be in the form "$tableName____$columnName". Value is an array with those keys: as, table, column, type, tableGroup
      */
     public function getColumnDescriptors() : array;
 }