Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo fmt to pre-commit #39

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Add cargo fmt to pre-commit #39

merged 2 commits into from
Jan 12, 2024

Conversation

sanders41
Copy link
Collaborator

No description provided.

@sanders41
Copy link
Collaborator Author

pre-commit.ci seems to still be having issues with Rust. Rust fmt works fine locally so I added it to pre-commit and disabled it in CI.

@sanders41 sanders41 merged commit 5118ba2 into main Jan 12, 2024
4 checks passed
@sanders41 sanders41 deleted the pre-commit-fmt branch January 12, 2024 23:48
@prrao87
Copy link
Member

prrao87 commented Jan 13, 2024

Yup, keeping GitHub runner time to a minimum and moving as much as possible to pre-commit makes sense! And it also makes sense why cargo fmt has no issues (it doesn't require a DB connection or anything).. This should work 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanders41 @prrao87