Add deploy to heroku #609
Open
Add deploy to heroku #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashlash
commented
Jun 30, 2022
| @@ -4,6 +4,7 @@ import redis from "redis"; | |||
| import env from "./env"; | |||
|
|
|||
| const client = redis.createClient({ | |||
| url: env.REDIS_URL, | |||
There was a problem hiding this comment.
The short-circuit syntax REDIS_URL || {} is not allowed with the @types/redis type definition.
server/redis.ts(6,35): error TS2769: No overload matches this call.
The last overload gave the following error.
Argument of type 'string | { password: string; host: string; port: number; }' is not assignable to parameter of type 'ClientOpts'.
Type 'string' has no properties in common with type 'ClientOpts'.
Comment on lines
+24
to
+39
| "MAIL_HOST": { | ||
| "required": false, | ||
| "value": "" | ||
| }, | ||
| "MAIL_PORT": { | ||
| "required": false, | ||
| "value": "" | ||
| }, | ||
| "MAIL_USER": { | ||
| "required": false, | ||
| "value": "" | ||
| }, | ||
| "MAIL_PASSWORD": { | ||
| "required": false, | ||
| "value": "" | ||
| } |
There was a problem hiding this comment.
This will allow users to manually verify the user using the method mentioned in #269 (comment)
Comment on lines
+12
to
+14
| "PGSSLMODE": { | ||
| "value": "no-verify" | ||
| }, |
There was a problem hiding this comment.
This is needed to connect to Heroku's Postgres without modifying the js code.
https://devcenter.heroku.com/articles/connecting-heroku-postgres#connecting-in-node-js
Comment on lines
+9
to
+11
| "NPM_CONFIG_PRODUCTION": { | ||
| "value": "false" | ||
| }, |
There was a problem hiding this comment.
This is needed for knex migrate to run properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow users to easily deploy to Heroku.
Additionally, it also adds support for DB and Redis URL configuration, which is required for Heroku deployment