Skip to content

Commit

Permalink
Revert "simplify"
Browse files Browse the repository at this point in the history
This reverts commit 4641449.
  • Loading branch information
evgeni committed Mar 13, 2024
1 parent 4641449 commit a9e2371
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 10 deletions.
24 changes: 14 additions & 10 deletions .github/workflows/foreman_plugin_js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ name: Foreman Plugin JavaScript
on:
workflow_call:
inputs:
plugin:
description: Plugin name
required: true
type: string
plugin_repository:
description: Plugin repository to use
required: false
Expand Down Expand Up @@ -85,7 +89,7 @@ jobs:
with:
repository: ${{ inputs.plugin_repository }}
ref: ${{ inputs.plugin_version }}
path: ./plugin
path: ${{ inputs.plugin }}
- name: "Set up Ruby ${{ matrix.ruby }}"
uses: ruby/setup-ruby@v1
with:
Expand All @@ -107,22 +111,22 @@ jobs:
- name: "Install Foreman NPM packages"
run: npm ci --no-audit --legacy-peer-deps
working-directory: ./foreman
- name: "Build plugin package-lock.json"
- name: "Build ${{ inputs.plugin }} package-lock.json"
run: npm install --package-lock-only --no-audit --legacy-peer-deps
working-directory: ./plugin
- name: "Install plugin NPM packages"
working-directory: ${{ inputs.plugin }}
- name: "Install ${{ inputs.plugin }} NPM packages"
run: npm ci --no-audit --legacy-peer-deps
working-directory: ./plugin
working-directory: ${{ inputs.plugin }}
- name: Archive package-lock.json
uses: actions/upload-artifact@v4
with:
name: package-lock-${{ env.ARTIFACT_SUFFIX }}.json
path: |
foreman/package-lock.json
plugin/package-lock.json
- name: Lint
${{ format('{0}/package-lock.json', inputs.plugin) }}
- name: Lint ${{ matrix.plugin }}
run: npm run lint
working-directory: ./plugin
- name: Run tests
working-directory: ${{ inputs.plugin }}
- name: Run ${{ matrix.plugin }} tests
run: npm test
working-directory: ./plugin
working-directory: ${{ inputs.plugin }}
1 change: 1 addition & 0 deletions .github/workflows/foreman_plugin_js_workflow_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ jobs:
name: JavaScript
uses: ./.github/workflows/foreman_plugin_js.yml
with:
plugin: katello
plugin_repository: Katello/katello

0 comments on commit a9e2371

Please sign in to comment.