Remove references to Pulpcore module stream for Pulpcore 3.39 #2597

ianballou · 2023-11-17T18:01:43Z

No CP should be needed, this is for Foreman 3.9

Pulpcore 3.39 is almost definitely losing its module stream, so it will no longer be needed in the docs.

Don't merge until after theforeman/puppet-pulpcore#315 get in.

Please cherry-pick my commits into:

Foreman 3.9/Katello 4.11

github-actions · 2023-11-17T18:05:28Z

The PR preview for a0f9fd0 is available at theforeman-foreman-documentation-preview-pr-2597.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

ekohl

Now dnf-module and dnf-modules are the same. Do we want to drop dnf-modules altogether now?

mjivraja · 2023-11-20T07:08:26Z

Now dnf-module and dnf-modules are the same. Do we want to drop dnf-modules altogether now?

I agree with this. dnf-modules becomes redundant with this PR.

ianballou · 2023-11-20T17:27:34Z

I've added a note to disable the pulpcore module when upgrading.

ianballou · 2023-11-20T17:30:42Z

I've removed references to dnf-modules

ianballou · 2023-11-20T18:27:04Z

The linting error appears to be an issue connecting to an external URL.

ekohl

Would it make sense to also add this as an upgrade warning in the release notes? So here:

foreman-documentation/guides/doc-Release_Notes/topics/katello.adoc

Lines 9 to 12 in 23d0164

    
           [id="katello-upgrade-warnings"] 
        
           == Upgrade Warnings 
        
           There are no upgrade warnings with Katello {KatelloVersion}.

guides/doc-Upgrading_Project/topics/proc_upgrading-smartproxy-server.adoc

guides/doc-Upgrading_Project/topics/proc_upgrading-a-connected-project-server.adoc

ianballou · 2023-11-22T13:23:28Z

Would it make sense to also add this as an upgrade warning in the release notes? So here:

foreman-documentation/guides/doc-Release_Notes/topics/katello.adoc

Lines 9 to 12 in 23d0164

[id="katello-upgrade-warnings"]

== Upgrade Warnings

There are no upgrade warnings with Katello {KatelloVersion}.

I was going to stick it in when I do my whole Katello 4.11 release notes update. I suppose I could put it in now.

ekohl · 2023-11-22T17:03:16Z

And now I wonder if we should also recommend removing the python39 module.

guides/common/modules/proc_preparing-a-host-for-external-databases.adoc

ianballou · 2023-12-05T22:28:09Z

@ekohl missed your earlier comments, I'll get to that.

ianballou · 2023-12-05T22:29:24Z

Would it make sense to also add this as an upgrade warning in the release notes? So here:

foreman-documentation/guides/doc-Release_Notes/topics/katello.adoc

Lines 9 to 12 in 23d0164

[id="katello-upgrade-warnings"]

== Upgrade Warnings

There are no upgrade warnings with Katello {KatelloVersion}.

I added it here: https://github.com/theforeman/foreman-documentation/pull/2602/files

maximiliankolb

Thanks Ian, LGTM. By now, I think we'll have to cherry-pick to 3.9. Please tick this box in your PR description.

Handing over to Ewoud for final ACK.

ekohl

This part is actually fixing an existing bug:

diff -Nrwu old/Installing_Proxy/index-satellite.html preview/nightly/Installing_Proxy/index-satellite.html
--- old/Installing_Proxy/index-satellite.html	2023-12-05 23:12:22.000000000 +0000
+++ preview/nightly/Installing_Proxy/index-satellite.html	2023-12-05 23:12:28.000000000 +0000
@@ -3497,7 +3497,7 @@
 <p>Enable the DNF modules:</p>
 <div class="listingblock">
 <div class="content">
-<pre class="nowrap"># dnf module enable satellite:el8</pre>
+<pre class="nowrap"># dnf module enable satellite-capsule:el8</pre>
 </div>
 </div>
 </li>

@Lennonka would you mind having a look about fixing that for downstream stable branches?

Lennonka · 2023-12-07T16:25:03Z

@Lennonka would you mind having a look about fixing that for downstream stable branches?

@ekohl I'm not sure I understand. Fixing what, how, and where?

evgeni · 2023-12-11T12:11:49Z

And now I wonder if we should also recommend removing the python39 module.

We absolutely should not, at least not as long as other tools (like ansible-runner) are using it.

Lennonka · 2023-12-11T16:38:19Z

@ekohl Downstream branches are copied from upstream. It must be, therefore, fixed in upstream and then it will be synced to downstream once merged. It can theoretically be done by correct cherry-picks to stable branches here in upstream, but I'm not sure all changes in this PR are desirable in older releases.

evgeni · 2023-12-11T21:22:05Z

No CP should be needed, this is for Foreman 3.9

3.9 was branched since, so a CP is needed ;)

(cherry picked from commit c6b2be6)

evgeni · 2023-12-12T07:13:23Z

To github.com:theforeman/foreman-documentation.git
2b461fd..b5dbca3 3.9 -> 3.9

Lennonka · 2023-12-12T19:49:03Z

@mjivraja @AkshayGadhaveRH Would you mind taking a look at this? I'm slammed :( and you might have a related bug for this in your team.

nixfu · 2023-12-12T20:47:42Z

FYI ran into this with testing upgrading from Katello 4.10 to 4.11 today, was getting tons of dnf/rpm errors until I figured it out.

THIS SHOULD BE IN THE RELEASE NOTES to disable the pulpcore module before upgrading, my eye just got lucky and noticed it in the nightly docs, but it will trip lots of people up who are upgrading.

ianballou · 2023-12-12T22:18:57Z

@nixfu the note will be there once they're merged https://github.com/theforeman/foreman-documentation/pull/2632/files#diff-a3acd643a9303d35f8f0d8c49bd0099a29f8576e1fa1648475da1258c8fad7deR44

It'll be in before official GA.

…eman#2597) (cherry picked from commit c6b2be6)

(cherry picked from commit c6b2be6)

pr-processor bot added the Not yet reviewed label Nov 17, 2023

ekohl reviewed Nov 17, 2023

View reviewed changes

ianballou force-pushed the remove-pulpcore-module-references branch from 1b0e7c5 to bfdf6d8 Compare November 20, 2023 17:26

ianballou force-pushed the remove-pulpcore-module-references branch from bfdf6d8 to 8543017 Compare November 20, 2023 17:30

ianballou requested a review from ekohl November 20, 2023 17:30

ianballou force-pushed the remove-pulpcore-module-references branch from 8543017 to 7fecc7e Compare November 20, 2023 18:13

ekohl requested changes Nov 20, 2023

View reviewed changes

guides/doc-Upgrading_Project/topics/proc_upgrading-smartproxy-server.adoc Show resolved Hide resolved

guides/doc-Upgrading_Project/topics/proc_upgrading-a-connected-project-server.adoc Show resolved Hide resolved

pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Nov 20, 2023

ekohl mentioned this pull request Nov 23, 2023

Fixes #36902 - Support Pulpcore 3.39, drop older versions theforeman/puppet-pulpcore#315

Merged

maximiliankolb reviewed Nov 27, 2023

View reviewed changes

guides/common/modules/proc_preparing-a-host-for-external-databases.adoc Show resolved Hide resolved

ianballou force-pushed the remove-pulpcore-module-references branch from 7fecc7e to 211d8b5 Compare December 1, 2023 17:22

pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Dec 1, 2023

ianballou requested review from ekohl and maximiliankolb December 5, 2023 22:27

ianballou force-pushed the remove-pulpcore-module-references branch from 211d8b5 to a0f9fd0 Compare December 5, 2023 23:10

Remove references to Pulpcore module stream for Pulpcore 3.39

a0f9fd0

maximiliankolb reviewed Dec 6, 2023

View reviewed changes

ekohl approved these changes Dec 7, 2023

View reviewed changes

pr-processor bot removed the Needs re-review label Dec 7, 2023

ianballou merged commit c6b2be6 into theforeman:master Dec 11, 2023
8 checks passed

ianballou deleted the remove-pulpcore-module-references branch December 11, 2023 20:08

evgeni pushed a commit that referenced this pull request Dec 12, 2023

Remove references to Pulpcore module stream for Pulpcore 3.39 (#2597)

b5dbca3

(cherry picked from commit c6b2be6)

ianballou added a commit to ianballou/foreman-documentation that referenced this pull request Dec 19, 2023

Remove references to Pulpcore module stream for Pulpcore 3.39 (thefor…

43e1e32

…eman#2597) (cherry picked from commit c6b2be6)

ianballou added a commit that referenced this pull request Dec 20, 2023

Remove references to Pulpcore module stream for Pulpcore 3.39 (#2597)

a99f42d

(cherry picked from commit c6b2be6)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove references to Pulpcore module stream for Pulpcore 3.39 #2597

Remove references to Pulpcore module stream for Pulpcore 3.39 #2597

ianballou commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading

ekohl left a comment

mjivraja commented Nov 20, 2023

ianballou commented Nov 20, 2023

ianballou commented Nov 20, 2023

ianballou commented Nov 20, 2023

ekohl left a comment

ianballou commented Nov 22, 2023

ekohl commented Nov 22, 2023

ianballou commented Dec 5, 2023

ianballou commented Dec 5, 2023

maximiliankolb left a comment

ekohl left a comment

Lennonka commented Dec 7, 2023

evgeni commented Dec 11, 2023

Lennonka commented Dec 11, 2023 •

edited

Loading

evgeni commented Dec 11, 2023

evgeni commented Dec 12, 2023

Lennonka commented Dec 12, 2023

nixfu commented Dec 12, 2023

ianballou commented Dec 12, 2023

	[id="katello-upgrade-warnings"]
	== Upgrade Warnings

	There are no upgrade warnings with Katello {KatelloVersion}.

Remove references to Pulpcore module stream for Pulpcore 3.39 #2597

Remove references to Pulpcore module stream for Pulpcore 3.39 #2597

Conversation

ianballou commented Nov 17, 2023 • edited Loading

github-actions bot commented Nov 17, 2023 • edited Loading

ekohl left a comment

Choose a reason for hiding this comment

mjivraja commented Nov 20, 2023

ianballou commented Nov 20, 2023

ianballou commented Nov 20, 2023

ianballou commented Nov 20, 2023

ekohl left a comment

Choose a reason for hiding this comment

ianballou commented Nov 22, 2023

ekohl commented Nov 22, 2023

ianballou commented Dec 5, 2023

ianballou commented Dec 5, 2023

maximiliankolb left a comment

Choose a reason for hiding this comment

ekohl left a comment

Choose a reason for hiding this comment

Lennonka commented Dec 7, 2023

evgeni commented Dec 11, 2023

Lennonka commented Dec 11, 2023 • edited Loading

evgeni commented Dec 11, 2023

evgeni commented Dec 12, 2023

Lennonka commented Dec 12, 2023

nixfu commented Dec 12, 2023

ianballou commented Dec 12, 2023

ianballou commented Nov 17, 2023 •

edited

Loading

github-actions bot commented Nov 17, 2023 •

edited

Loading

Lennonka commented Dec 11, 2023 •

edited

Loading