Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPAM method for Infoblox #2693

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add IPAM method for Infoblox #2693

merged 1 commit into from
Feb 19, 2024

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Jan 23, 2024 •
edited
Loading

It seems counter-intuitive that the IPAM method to use with the Infoblox DHCP provider is "DHCP" and not "External IPAM", when, technically, Infoblox is an "external" DHCP service.

https://bugzilla.redhat.com/show_bug.cgi?id=2134225

Please cherry-pick my commits into:

  • Foreman 3.9/Katello 4.11 (planned Satellite 6.15)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
  • We do not accept PRs for Foreman older than 3.1.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

The PR preview for 17ad695 is available at theforeman-foreman-documentation-preview-pr-2693.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@ekohl
Copy link
Member

ekohl commented Jan 23, 2024

This is because the IPAM implementation is relatively new and we haven't ported over all code. I agree with you, but to make it worse: I don't think anyone is working on this

@Lennonka Lennonka force-pushed the SAT-15346-infoblox-ipam branch from aa57455 to 64fb729 Compare January 24, 2024 15:03
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author Needs re-review and removed Not yet reviewed Waiting on contributor Requires an action from the author labels Jan 29, 2024
@Lennonka Lennonka force-pushed the SAT-15346-infoblox-ipam branch from 0bd973e to 1199f47 Compare January 29, 2024 20:22
@Lennonka Lennonka requested a review from ekohl January 29, 2024 20:25
@Lennonka
Copy link
Contributor Author

I attempted a larger cleanup.

@Lennonka Lennonka requested a review from ekohl January 30, 2024 18:09
@Lennonka Lennonka force-pushed the SAT-15346-infoblox-ipam branch from f047379 to a428680 Compare January 30, 2024 21:35
adamlazik1
adamlazik1 reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@adamlazik1 adamlazik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good stylewise, I only have one small suggestion.

guides/common/modules/proc_installing-the-dhcp-infoblox-module.adoc Outdated Show resolved Hide resolved
@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Needs re-review labels Jan 31, 2024
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Jan 31, 2024
@Lennonka Lennonka added Waiting on contributor Requires an action from the author and removed Needs re-review labels Jan 31, 2024
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Jan 31, 2024
@Lennonka Lennonka requested a review from ekohl January 31, 2024 23:15
@Lennonka
Copy link
Contributor Author

@ekohl Ack?

@Lennonka Lennonka force-pushed the SAT-15346-infoblox-ipam branch 4 times, most recently from de73cf4 to 3780f36 Compare February 13, 2024 18:50
ekohl
ekohl approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems counter-intuitive that the IPAM method to use with the Infoblox DHCP provider is "DHCP" and not "External IPAM", when, technically, Infoblox is an "external" DHCP service.

From Foreman there is no "external" DHCP service. It just knows how to talk to a Smart Proxy. How that Smart Proxy decides to make DHCP happen is an implementation detail.

IPAM set to DHCP means to use the DHCP implementation as an IPAM. External IPAM requires https://github.com/grizzthedj/smart_proxy_ipam (or theforeman/smart-proxy#810). Currently that's not packaged so not really supported.

Other than some very minor things I think this is ready.

guides/common/modules/proc_installing-the-dhcp-infoblox-module.adoc Outdated Show resolved Hide resolved
guides/common/modules/proc_installing-the-dns-infoblox-module.adoc Outdated Show resolved Hide resolved
@Lennonka Lennonka force-pushed the SAT-15346-infoblox-ipam branch from 3780f36 to 17ad695 Compare February 19, 2024 12:16
@Lennonka
Copy link
Contributor Author

@maximiliankolb Would you mind signing this off? :)

maximiliankolb
maximiliankolb approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any experience with Infoblox, but your diff LGTM!

@Lennonka Lennonka merged commit 836fd17 into theforeman:master Feb 19, 2024
8 checks passed
@Lennonka
Copy link
Contributor Author

Cherry-picked:

@Lennonka Lennonka deleted the SAT-15346-infoblox-ipam branch February 26, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamlazik1 adamlazik1 adamlazik1 left review comments

@maximiliankolb maximiliankolb maximiliankolb approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lennonka @ekohl @maximiliankolb @adamlazik1