-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagram of installer-based provisioning with HTTP boot #3305
Add diagram of installer-based provisioning with HTTP boot #3305
Conversation
The PR preview for 562fcca is available at theforeman-foreman-documentation-preview-pr-3305.surge.sh The following output files are affected by this PR: |
Updated based on feedback from #3304 |
We should tweak the diagram in such way so that it doesn't contain TFTP. Foreman uses the TFTP folder to do some steps, but HTTP boot doesn't use the TFTP protocol. |
ec1a4b5
to
438b864
Compare
438b864
to
2723843
Compare
I've made an attempt to tweak the diagram so that it uses Proxy instead of TFTP as a participant, but I'm not sure if it's technically correct. We'll discuss tomorrow during our session. |
participant "Provisioned\nHost" as Host | ||
participant "Foreman" as Foreman | ||
participant "Foreman\nProxy" as Proxy | ||
participant DHCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the #3304 PR, there is a TFTP participant
. Should we add the participant HTTP
here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stejskalleos I believe that we discussed last week that we will not introduce an HTTP participant but treat the Foreman Proxy as the server that provides HTTP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Co-authored-by: Leos Stejskal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍏 LGTM
What changes are you introducing?
Adding a sequence diagram of installer-based provisioning with HTTP boot. Using PlantUML to build the diagram.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Preparation for improvements of Provisioning hosts. The diagram will be used later to explain the workflow of the provisioning method.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A