Use same manifest for upstr and downstr servers; add relevant links #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guides/common/modules/proc_importing-a-subscription-manifest-into-foreman-server.adoc
Outdated
Show resolved
Hide resolved
|
The PR preview for c876694 is available at theforeman-foreman-documentation-preview-pr-3505.surge.sh The following output files are affected by this PR: |
rh-max
force-pushed
the
installing-disconnected-manifest-fixes
branch
from
871d798 to
4abdfa5
Compare
|
@maximiliankolb Do you know why the new xrefs fail? |
guides/common/modules/proc_importing-a-subscription-manifest-into-foreman-server.adoc
Outdated
Show resolved
Hide resolved
|
@Lennonka Could you PTAL? I want to make sure that the set of links I added to the two places is the correct one. Thanks. |
Lennonka
requested changes
Dec 9, 2024
guides/common/modules/proc_importing-a-subscription-manifest-into-foreman-server.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-projectserver-to-synchronize-content-over-a-network.adoc
Outdated
Show resolved
Hide resolved
pr-processor
bot
added
the
Waiting on contributor
…onize-content-over-a-network.adoc Co-authored-by: Lena Ansorgová <[email protected]>
pr-processor
bot
added
Needs re-review
and removed
Waiting on contributor
…nto-foreman-server.adoc Co-authored-by: Lena Ansorgová <[email protected]>
Lennonka
reviewed
Dec 9, 2024
Comment on lines
8
to
+10
| * You imported the subscription manifest on both the upstream and downstream {ProjectServer}. | ||
| Use the same manifest. | ||
| For more information, see xref:Importing_a_Red_Hat_Subscription_Manifest_into_Server_{context}[]. |
There was a problem hiding this comment.
Suggested change
| * You imported the subscription manifest on both the upstream and downstream {ProjectServer}. | |
| Use the same manifest. | |
| For more information, see xref:Importing_a_Red_Hat_Subscription_Manifest_into_Server_{context}[]. | |
| * You imported the same subscription manifest on both the upstream and downstream {ProjectServer}. | |
| For more information, see xref:Importing_a_Red_Hat_Subscription_Manifest_into_Server_{context}[]. |
Comment on lines
+28
to
+29
| You will use the same manifest in | ||
| xref:configuring-server-to-synchronize-content-over-a-network_{context}[]. |
There was a problem hiding this comment.
Suggested change
| You will use the same manifest in | |
| xref:configuring-server-to-synchronize-content-over-a-network_{context}[]. | |
| You will use the same manifest in xref:configuring-server-to-synchronize-content-over-a-network_{context}[]. |
| ifndef::orcharhino[] | ||
| For more information, see {RHDocsBaseURL}subscription_central/1-latest/html/getting_started_with_rhel_system_registration/adv-reg-rhel-using-rhsm_#using_manifests_con[Using manifests for a disconnected Satellite Server] in _Subscription Central_. | ||
| For more information, see {RHDocsBaseURL}subscription_central/1-latest/html-single/creating_and_managing_manifests_for_a_disconnected_satellite_server/index[Creating and managing manifests for a disconnected {ProjectServer}] in _Subscription Central_. |
There was a problem hiding this comment.
Suggested change
| For more information, see {RHDocsBaseURL}subscription_central/1-latest/html-single/creating_and_managing_manifests_for_a_disconnected_satellite_server/index[Creating and managing manifests for a disconnected {ProjectServer}] in _Subscription Central_. | |
| For more information, see {RHDocsBaseURL}subscription_central/1-latest/html-single/creating_and_managing_manifests_for_a_disconnected_satellite_server/index[Creating and managing manifests for a disconnected Satellite Server] in _Subscription Central_. |
For Foreman documentation, we would normally use the attribute. But in this case, the title of the referenced docs shouldn't change with the build, so let's hard code it.
The same below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-28286
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: