-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for rolling content views #3518
base: master
Are you sure you want to change the base?
Conversation
Docs have been reviewed internally and are public for orcharhino. Requires Katello/katello#11240 |
The PR preview for 8ab84d3 is available at theforeman-foreman-documentation-preview-pr-3518.surge.sh The following output files are affected by this PR: |
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
03cc547
to
211a847
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased to "master" and applied all feedback by Jeremy.
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
TODO: Mention rolling CV in the planning guide. Refs #3456 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few nitpicks.
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
Refs PR 11240 in katello on GitHub Refs 38048 in Redmine
211a847
to
8ab84d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lena, applied both suggestions and rebased to "master".
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_creating-a-rolling-content-view.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect
The "Best practices" could use some updates too: https://docs.theforeman.org/nightly/Managing_Content/index-katello.html#best-practices-for-content-views_content-management The second bullet could be updated to mention rolling content views. Unrelated, but I can also see splitting out the composite-CV stuff into their own list there. |
What changes are you introducing?
documentation for rolling content views:
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
new feature -> new docs
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Refs PR 11240 in katello on GitHub
Refs 38048 in Redmine
Checklists
Please cherry-pick my commits into:
no cherry-picks