Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for rolling content views #3518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

documentation for rolling content views:

image

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

new feature -> new docs

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Refs PR 11240 in katello on GitHub
Refs 38048 in Redmine

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:
no cherry-picks

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective Needs style review Requires a review from docs style/grammar perspective Waiting for code Requires merge of related code in another repository before it can be merged and removed Not yet reviewed labels Dec 11, 2024
@maximiliankolb
Copy link
Contributor Author

Docs have been reviewed internally and are public for orcharhino. Requires Katello/katello#11240

Copy link

github-actions bot commented Dec 11, 2024

Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to "master" and applied all feedback by Jeremy.

@maximiliankolb
Copy link
Contributor Author

TODO: Mention rolling CV in the planning guide. Refs #3456 (comment)

Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few nitpicks.

@pr-processor pr-processor bot added the Waiting on contributor Requires an action from the author label Dec 17, 2024
Refs PR 11240 in katello on GitHub
Refs 38048 in Redmine
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Dec 18, 2024
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lena, applied both suggestions and rebased to "master".

Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Dec 18, 2024
@jeremylenz
Copy link
Contributor

The "Best practices" could use some updates too: https://docs.theforeman.org/nightly/Managing_Content/index-katello.html#best-practices-for-content-views_content-management

The second bullet could be updated to mention rolling content views.

Unrelated, but I can also see splitting out the composite-CV stuff into their own list there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective Waiting for code Requires merge of related code in another repository before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants