Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SSL certificate paths based on platform OS #3529

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

  • Hide link to RHEL docs for Foreman on Deb
  • Note that Debian/Ubuntu only accept ".crt" as file extension

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

fixes 3500

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

* Hide link to RHEL docs for Foreman on Deb
* Note that Debian/Ubuntu only accept ".crt" as file extension

fixes 3500
Copy link

The PR preview for 8ce8b94 is available at theforeman-foreman-documentation-preview-pr-3529.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliankolb maximiliankolb removed the request for review from asteflova December 18, 2024 10:43
@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective Needs tech review Requires a review from the technical perspective labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs tech review Requires a review from the technical perspective style review done No issues from docs style/grammar perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix path + cmd for custom certs on Debian/Ubuntu
2 participants