Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DNS, DHCP, and TFTP content to a new guide #3530

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Lennonka
Copy link
Contributor

What changes are you introducing?

Extracting DNS, DHCP, and TFTP configuration from Installing guides to a special new guide

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

The network services can be configured at any later time. They don't have to be configured during installation. The installation guides are too long.

https://issues.redhat.com/browse/SAT-27225

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

Copy link

github-actions bot commented Dec 16, 2024

The PR preview for c105b20 is available at theforeman-foreman-documentation-preview-pr-3530.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@@ -2,6 +2,7 @@

:AdministeringDocTitle: Administering {ProjectName}
:AdministeringAnsibleDocTitle: Managing {Project} with Ansible
:AdministeringNetworkDocTitle: Administering network services
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go for a more specific title because there are aspects of networking that are not in this new guide. I recommend either "Configuring DNS, DHCP, and TFTP" or possibly "Configuring external network services." What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's more like Integrating network services because I think it should also cover configuring using an external network service. Taking upstream as an example, there's Amazon Route53 integration and for sure you're not administrating that service yourself but only integrate with it. Less extreme I'd say the same thing can be true for Infoblox or PowerDNS (which another department in your org can run).

Something I haven't made up my mind about is focusing it more on provisioning. At least DHCP and TFTP are solely used when you provision. DNS can also be used when a host is renamed, but it's a bit of an edge case IMHO.

Taking a step back, you could look at making the provisioning guide aimed at users where this new guide is aimed at admins.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide currently includes setting up DNS, etc, internally within the Sat environment. I am not sure that could be considered integration. Should we use this guide only for integration with external services?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide currently includes setting up DNS, etc, internally within the Sat environment. I am not sure that could be considered integration. Should we use this guide only for integration with external services?

It's very limiting. You will have setting up DNS integration in one or two guides (like Installing Server and Installing Proxy) and then some variants of DNS integration in this new guide.

What I would like to see is a guide that says "here's how you set up DNS integration and these are your options", like I already laid out in #2957. And then do the same for DHCP.

I also think we should drop the chapters that set up all integrations at the same time because it gives the impression you must run them together, which is completely false.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we should drop the chapters that set up all integrations at the same time because it gives the impression you must run them together, which is completely false.

@ekohl Agree. Since that is outside the scope of this PR, I will create a task to split apart those chapters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lennonka Re: title. How about "Configuring DNS, DHCP, and TFTP integration"? I recommend keeping titles fairly specific. I think "Administering" sounds odd because we don't administer external services; we configure them. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like "Configuring DNS, DHCP, and TFTP integration" because AFAIK it's about adding entries for those services to Foreman, hence "integration" works nicely, and eventually configuring those services when they are managed by Foreman.

@apinnick
Copy link
Contributor

apinnick commented Dec 17, 2024

@Lennonka I looked at your draft PR and thought about possible structure. Please see the new "Proposed TOC 2" frame in the Miro board and let me know what you think.

Here's a screenshot for anyone who does not have access to the Miro board.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants