-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TFTP-boot provisioning in IPv6 networks #3532
Open
Lennonka
wants to merge
3
commits into
theforeman:master
Choose a base branch
from
Lennonka:add-ipv6-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−14
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
guides/common/modules/con_foreman-and-dhcp-configuration.adoc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
[id="{project-context}-and-dhcp-configuration"] | ||
= {Project} and DHCP configuration | ||
|
||
{Project} manages DHCP reservations through a DHCP {SmartProxy}. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
guides/common/modules/ref_options-in-unmanaged-dhcpv6.adoc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
[id="options-in-unmanaged-dhcpv6"] | ||
= Options in unmanaged DHCPv6 | ||
|
||
To provision hosts over TFTP in an IPv6-only network, configure the DHCP server to respond with the `bootfile-url` DHCP option. | ||
{Project} cannot manage the DHCPv6 service, therefore, you have to configure your DHCP server manually. | ||
|
||
`bootfile-url`:: | ||
The URL value of this option has to point to a file on TFTP {SmartProxy} that is a first-stage boot loader, such as `pxelinux.0`. | ||
Example configuration: | ||
+ | ||
[options="nowrap" subs="+quotes,attributes,verbatim"] | ||
---- | ||
"option-data": [ | ||
{ | ||
"name": "bootfile-url", | ||
"data": "tftp://2001:db8:1::1/pxelinux.0" | ||
} | ||
], | ||
---- |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this was already there, but this behavior has changed a long time ago. In Foreman 2.0 there was theforeman/foreman@60c03b6 which deprecated the old reverse DNS lookup for Smart Proxies incapable of a new feature (for n-1 support). In Foreman 2.5 this deprecated behavior was removed with theforeman/foreman@f3231f6.
The way it now works is:
--foreman-proxy-tftp-servername
in the installer)It is up to the DHCP provider server to deal with a hostname and it depends on the implementation how this exactly works. For ISC DHCP the Smart Proxy now resolves the address:
https://github.com/theforeman/smart-proxy/blob/7060ce3e3951f070475e0c977fd3bf93e335d810/modules/dhcp_common/isc/omapi_provider.rb#L203-L215
And in reviewing this PR I've realized we should really use the option to set the tftp server name and let ISC DHCP deal with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekohl Thank you. I've created a separate PR so that we can cherry pick it.
Please review #3540