Remove upstream EL7 client repository #3596
Open
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The option says --content-label so a name should be used.
Foreman 3.14 drops EL7 builds for the client repositories and since the packages are gone, we can no longer mention it. It also adds a release note to make that obvious.
|
The PR preview for 4664bd9 is available at theforeman-foreman-documentation-preview-pr-3596.surge.sh The following output files are affected by this PR:
|
maximiliankolb
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
one minor suggestion that does not block this PR. Style-wise LGTM; tech ACK: matches https://yum.theforeman.org/client/
- Client for EL7 for Foreman 3.13 ✔️ as expected
- Client for EL7 for Foreman nightly: ❌ as expected
| @@ -157,11 +157,7 @@ | |||
| :RepoRHEL8ServerSatelliteUtils: satellite-utils-{RepoSatelliteVersion}-for-rhel-8-x86_64-rpms | |||
|
|
|||
| // RHEL 7 Satellite repos | |||
| :RepoRHEL7ServerSatelliteMaintenanceProjectVersion: rhel-7-server-satellite-maintenance-{RepoSatelliteVersion}-rpms | |||
| :RepoRHEL7ServerSatelliteServerProjectVersion: rhel-7-server-satellite-{RepoSatelliteVersion}-rpms | |||
| :RepoRHEL7ServerSatelliteServerProjectVersionPrevious: rhel-7-server-satellite-{ProjectVersionPrevious}-rpms | |||
| :RepoRHEL7ServerSatelliteToolsProjectVersion: rhel-7-server-satellite-client-6-rpms | |||
There was a problem hiding this comment.
Looks like this attributes is only used once as value for another attribute. Out of scope but could be simplified:
$ rg -i RepoRHEL7ServerSatelliteToolsProjectVersion
guides/common/attributes-satellite.adoc
163::RepoRHEL7ServerSatelliteToolsProjectVersion: rhel-7-server-satellite-client-6-rpms
169::project-client-RHEL7-url: {RepoRHEL7ServerSatelliteToolsProjectVersion}
There was a problem hiding this comment.
I debated that, but I find it worrying we don't have project-client-RHEL9-url either so I decided to leave it out of scope. There's also a chance we'll just drop RHEL 7 in Satellite, but I don't know what the plan for that is right now.
maximiliankolb
added
tech review done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Foreman 3.14 has dropped the EL7 client repository and this documents that change.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I have not completely reviewed all the content bits to see if they're still correct.
Checklists
Please cherry-pick my commits into: