Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add renovate #1959

Closed
wants to merge 1 commit into from
Closed

add renovate #1959

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 6, 2023

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Nov 6, 2023

You can see this in action at https://github.com/evgeni/foreman-infra/pulls :)

- name: Self-hosted Renovate
uses: renovatebot/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't trigger CI and will have to be changed to a "real" token, see https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow:

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur.

@evgeni
Copy link
Member Author

evgeni commented Nov 6, 2023

Instead of using a github action, we could also use the Renovate app (https://github.com/marketplace/renovate) which would not have the token issue, I am happy with either, but I'd like the feature of $thing bumping our deps.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the noise in updating the GH action version I'm leaning to the app.

- name: Checkout
uses: actions/checkout@v4
- name: Self-hosted Renovate
uses: renovatebot/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will generate a lot of noise. Not too happy with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yepp, they don't have a "rolling" branch :(

@evgeni
Copy link
Member Author

evgeni commented Nov 7, 2023

Starting setting up the app in #1961

@evgeni
Copy link
Member Author

evgeni commented Nov 9, 2023

closing in favor of #1961

@evgeni evgeni closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants