Drop exim module #2005
Open
Drop exim module #2005
+0
−910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased now that CI should be green again. |
That would be #1846 |
|
I noticed we have exim on web01. |
|
And web01 is gone |
evgeni
approved these changes
Dec 21, 2024
This module was appled on the old redmine.theforeman.org box, but the new redmine01.conova.theforeman.org no longer uses exim which means it can be dropped.
ekohl
commented
Dec 21, 2024
| @@ -11,7 +11,6 @@ PuppetSyntax.exclude_paths = ["vendor/**/*"] | |||
| require 'puppet-lint/tasks/puppet-lint' | |||
| PuppetLint::RakeTask.new :lint do |config| | |||
| config.pattern = PuppetSyntax.manifests_paths | |||
| config.ignore_paths = ['modules/exim/**/*.pp'] | |||
There was a problem hiding this comment.
Rebased and updated this line to fully get rid of it. Waiting for CI now to see if it's still happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module was appled on the old redmine.theforeman.org box, but the new redmine01.conova.theforeman.org no longer uses exim which means it can be dropped.
The question is if we should have some (minimal) postfix config that just ensures it's installed and running. We did see that on Jenkins where that now has been done manually.
Fixes #1692