Update NodeJS to 18.x on Ubuntu with Foreman 3.14+ #2190
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of dropping NodeJS 14 this updates nodesource to NodeJS 18. That's also the version included in Ubuntu 24.04. It drops the conditionals for Foreman < 3.9 since those are gone now.
evgeni
approved these changes
Dec 19, 2024
|
Do we need to rebuild all Ubuntu packages after merging this? |
|
No, this shouldn't be necessary. The built assets do not differ based on the Node version they were built with (or at least should not!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of dropping NodeJS 14 this updates nodesource to NodeJS 18. That's also the version included in Ubuntu 24.04.
It drops the conditionals for Foreman < 3.9 since those are gone now.