Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #31022 - Use an isolated Puppet environment #585

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixes #31022 - Use an isolated Puppet environment #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions hooks/boot/01-kafo-hook-extensions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,13 @@ def ensure_packages(packages, state = 'installed')
end
end

def apply_puppet_code(code)
bin_path = Kafo::PuppetCommand.search_puppet_path('puppet')
Open3.capture3(*Kafo::PuppetCommand.format_command("echo \"#{code}\" | #{bin_path} apply --detailed-exitcodes"))
def apply_puppet_code(code, use_noop=true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this whole thing would live in Kafo to be honest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of, but I wasn't sure how things would behave if you have multiple definitions of that. I'd still be open to it.

puppet_execution_environment do |env|
options = ['--detailed-exitcodes']
settings = {noop: use_noop && app_value(:noop)}
command = env.build_command(code, options: options, settings: settings)
Open3.capture3(*command)
end
end

def fail_and_exit(message, code = 1)
Expand Down