Do not use tilde specifier for PUPPET_VERSION read from environment

[dosas]

when specifing a specific version this version should be used

[ekohl]

👎 on this because I don't see any good reason for this. IMHO you want both a lower and upper bound and ~> gives you that (most of the time).

At first when I saw the summary I thought you'd simplify it to something like:

gem 'puppet', ENV.fetch('PUPPET_VERSION', '~> 7.0')

That I could be open to since it gives complete control, but <= is just not the right way.

Also, it now breaks because this part doesn't work anymore:

foreman-installer/.github/workflows/test.yml

Lines 28 to 33 in 67702be

	- ruby: '2.7'
	puppet: '7.0'
	- ruby: '3.0'
	puppet: '7.0'
	- ruby: '3.2'
	puppet: '8.0'

Suddenly ~> 8.0 turned into <= 8.0 which means you no longer get the latest 8.x but just 8.0 or worse, 7.x.

[ekohl]

ping @dosas