Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fdi-service dependencies and build RPMs #11221

Draft
wants to merge 1 commit into
base: rpm/develop
Choose a base branch
from

Conversation

stejskalleos
Copy link

No description provided.

@stejskalleos
Copy link
Author

The rpmlint is failing on:

E: unused-rpmlintrc-filter "macro-in-comment"
foreman-discovery-image-service.spec: E: unused-rpmlintrc-filter "unversioned-explicit-obsoletes"
foreman-discovery-image-service.spec: E: unused-rpmlintrc-filter "unversioned Obsoletes"

I need to learn how to fix them as the rpmlint help for each failure is not very helpful.

@stejskalleos
Copy link
Author

I found a way how to build FDI without these meta-packages; maybe they won't be needed anymore.

@stejskalleos stejskalleos marked this pull request as draft September 11, 2024 10:18
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't commit the RPM files. We probably lack a .gitignore line for that.

I would also prefer it if we created a proper gem for text interface and then package that. Right now https://github.com/theforeman/foreman-discovery-image has a root/share/ruby with some code and this reflects the requirements that it needs. Not really easy to maintain IMHO.

@stejskalleos
Copy link
Author

I found a way to make this meta-package obsolete. I'll keep the PR open for now, and when the EL9 changes are approved, I will update it to remove the spec.

@stejskalleos
Copy link
Author

Waiting for #11268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants