Refs #18539 - Expand foreman_{assets,webpack}_plugin macros #11233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These macros now include the directories above it so plugins properly own them. That means on removal (and upgrade is a special case of removal) they're cleaned up. This means the macro now only works in the %files section, but in practice that's the only place it's used.
|
My thought was to fork the COPR repo that was created for this PR and build a plugin there. |
|
Of course I forgot to set up the repos. https://copr.fedorainfracloud.org/coprs/ekohl/foreman-packaging-pr-11233/build/8009796/ tries it again. |
|
I'm tempted to say this is a relevant build failure. |
|
Well, damn, that macro is used in the precompile_plugin macro. 🐢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These macros now include the directories above it so plugins properly own them. That means on removal (and upgrade is a special case of removal) they're cleaned up.
This means the macro now only works in the %files section, but in practice that's the only place it's used.