-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop EL8 bits from Nightly #11332
Drop EL8 bits from Nightly #11332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have more files, like modulemd/modulemd-foreman-el8.yaml
and modulemd/modulemd-katello-el8.yaml
. Then there's the group of shell scripts that still default to el8 in many places:
add_npm_package.sh
remove_from_comps
add_to_comps.rb
add_pypi_package.sh
add_gem_package.sh
Then we have a bit of a wildcard and that's rhel8-kickstart-setup
. @evgeni or @ehelms know what we should do with this? It's following the upstream name, but should that be updated to rhel9 now?
I started #11370 to make changing the comps files a bit easier. |
17ba0c1
to
2d4b8c2
Compare
I had the |
Do we also want to keep mock config for el8 around? I know we've kept the one for el7, but is it still needed? |
Since we still have clients on EL8, I'm not sure if we need to drop mock now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can deal with the add scripts in my PR. This PR now looks OK, but please fix up theforeman/jenkins-jobs#495 so we can merge this.
I forgot about theforeman/jenkins-jobs#495 sorry, just pushed the change there. |
No description provided.