Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop EL8 bits from Nightly #11332

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

Odilhao
Copy link
Member

@Odilhao Odilhao commented Oct 9, 2024

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have more files, like modulemd/modulemd-foreman-el8.yaml and modulemd/modulemd-katello-el8.yaml. Then there's the group of shell scripts that still default to el8 in many places:

  • add_npm_package.sh
  • remove_from_comps
  • add_to_comps.rb
  • add_pypi_package.sh
  • add_gem_package.sh

Then we have a bit of a wildcard and that's rhel8-kickstart-setup. @evgeni or @ehelms know what we should do with this? It's following the upstream name, but should that be updated to rhel9 now?

@ekohl
Copy link
Member

ekohl commented Oct 22, 2024

I started #11370 to make changing the comps files a bit easier.

@Odilhao Odilhao force-pushed the rpm/develop-drop-el8 branch from 17ba0c1 to 2d4b8c2 Compare October 22, 2024 17:48
@Odilhao Odilhao requested a review from a team as a code owner October 22, 2024 17:48
@Odilhao
Copy link
Member Author

Odilhao commented Oct 22, 2024

I had the add_* scripts modified here to drop EL8, I removed and force pushed again

@adamruzicka
Copy link

Do we also want to keep mock config for el8 around? I know we've kept the one for el7, but is it still needed?

@Odilhao
Copy link
Member Author

Odilhao commented Oct 23, 2024

Do we also want to keep mock config for el8 around? I know we've kept the one for el7, but is it still needed?

Since we still have clients on EL8, I'm not sure if we need to drop mock now.

@Odilhao Odilhao requested a review from ekohl October 24, 2024 15:05
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can deal with the add scripts in my PR. This PR now looks OK, but please fix up theforeman/jenkins-jobs#495 so we can merge this.

@Odilhao
Copy link
Member Author

Odilhao commented Oct 24, 2024

I forgot about theforeman/jenkins-jobs#495 sorry, just pushed the change there.

@ekohl ekohl merged commit 2c53807 into theforeman:rpm/develop Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants