Update katello package dependencies #8637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ekohl
commented
Oct 26, 2022
| BuildRequires: rubygem(pulp_rpm_client) >= 3.17.0 | ||
| BuildRequires: rubygem(pulp_rpm_client) < 3.18.0 | ||
| BuildRequires: rubygem(pulpcore_client) >= 3.21.0 | ||
| BuildRequires: rubygem(pulpcore_client) < 3.22.0 |
There was a problem hiding this comment.
@evgeni any thoughts on dropping the version bounds? or at least the upper bound? Since this is a proper gem we should have automatic dependencies based on the gemspec. AFAIK that's still verified, which would make the build fail, just later than it is now. It'd reduce the churn on keeping this in sync. At least until #8414.
To be clear, I think it should be a separate effort, but it can help us. Especially if we're going to build more nightly/scratch packages.
There was a problem hiding this comment.
Cool. Not sure I can get to it soon, but I'll keep it in mind.
|
[test rpm] |
|
Repoclosure fails because it hasn't been mashed yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.