Fix Style/RedundantAssignment cop

This cop efficiently detects and fixes unnecessary variable assignments
before returning values in methods. Also improves redability of code
by reducing clutter.

https://docs.rubocop.org/rubocop/cops_style.html#styleredundantassignment

app/helpers/form_helper.rb

@@ -317,8 +317,7 @@ def add_label(options, f, attr)
     if options[:label_help].present?
       label += ' '.html_safe + popover("", options[:label_help], options[:label_help_options] || {})
     end
-    label = label.present? ? label_tag(attr, label.to_s + required_mark.to_s, :class => label_size + " control-label") : ''
-    label
+    label.present? ? label_tag(attr, label.to_s + required_mark.to_s, :class => label_size + " control-label") : ''
   end
 
   def check_required(options, f, attr)

app/models/compute_resource.rb

@@ -375,8 +375,7 @@ def vm_compute_attributes(vm)
     vm_attrs = vm_attrs.reject { |k, v| k == :id }
 
     vm_attrs = set_vm_volumes_attributes(vm, vm_attrs)
-    vm_attrs = set_vm_interfaces_attributes(vm, vm_attrs)
-    vm_attrs
+    set_vm_interfaces_attributes(vm, vm_attrs)
   end
 
   def vm_ready(vm)

app/models/host/managed.rb

@@ -534,8 +534,7 @@ def apply_inherited_attributes(attributes, initialized = true)
       attributes[attribute] = value
     end
 
-    attributes = apply_facet_attributes(new_hostgroup, attributes)
-    attributes
+    apply_facet_attributes(new_hostgroup, attributes)
   end
 
   def hash_clone(value)

app/services/proxy_reference_registry.rb

@@ -44,8 +44,7 @@ def join_reference_arrays(references, other_references)
         end
         memo
       end
-      references = references.concat to_add
-      references
+      references.concat to_add
     end
 
     private

script/dynflowd

@@ -37,7 +37,7 @@ class ArgvParser
   end
 
   def banner(file)
-    banner = <<~BANNER
+    <<~BANNER
       Run Dynflow executor for Foreman tasks.
 
       Usage: #{File.basename(file)} [options] ACTION"
@@ -56,7 +56,7 @@ class ArgvParser
       * run     - run the executor in foreground
 
     BANNER
-    banner
+
   end
 end