Fixes #37636 - remove usage of "@theforeman/test" #10239
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaAga
force-pushed
the
remove-foreman-test-import
branch
from
ce4011b
to
bd82e9d
Compare
MariaAga
force-pushed
the
remove-foreman-test-import
branch
10 times, most recently
from
915675e
to
f2c89fd
Compare
MariaAga
force-pushed
the
remove-foreman-test-import
branch
15 times, most recently
from
b37548d
to
f757e1d
Compare
MariaAga
force-pushed
the
remove-foreman-test-import
branch
4 times, most recently
from
0382a92
to
49acfba
Compare
MariaAga
force-pushed
the
remove-foreman-test-import
branch
2 times, most recently
from
2be51ef
to
91d4309
Compare
MariaAga
force-pushed
the
remove-foreman-test-import
branch
from
91d4309
to
a249de8
Compare
MariaAga
commented
Sep 12, 2024
MariaAga
commented
Sep 12, 2024
MariaAga
commented
Sep 12, 2024
MariaAga
commented
Sep 12, 2024
MariaAga
commented
Sep 12, 2024
MariaAga
commented
Sep 12, 2024
MariaAga
changed the title
MariaAga
force-pushed
the
remove-foreman-test-import
branch
from
a249de8
to
c12831e
Compare
MariaAga
force-pushed
the
remove-foreman-test-import
branch
from
c12831e
to
2f92ad0
Compare
MariaAga
commented
Oct 9, 2024
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| function linkEslintPlugin(runPath = process.cwd()) { |
There was a problem hiding this comment.
npm link too complicated (need package.json with specific naming, deletes files sometimes) while creating a symlink is simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards removing theforeman/test, context: https://community.theforeman.org/t/do-we-want-to-keep-foreman-js/37644
had to do all 3 in one pr since:
[Fixes #37636 - remove "@theforeman/test" imports] - relying on jest config having resolved foremanReact into a valid path, otherwise I would have had to use relative path instead and thats too much work
[Fixes #37637 - Test plugins from foreman core] - for some reason npm lint needs
@theforeman/testpackage, so it was easier to stop using it instead of working around it. left some of the theforeman eslint packages to remove later, as this commit only deals with whats necessary to get lint to work after removing theforeman/test.eslintrc turned into script/lint/lint_core_config.js, no changes except for formatting