[WIP] Remove foreman vendor #10342
[WIP] Remove foreman vendor #10342
Conversation
github-actions
bot
added
UI
Legacy JS
| export const visit = url => { | ||
| window.location.href = url; | ||
| }; | ||
|
|
||
| export const reloadPage = () => { | ||
| window.location.reload(); | ||
| }; |
| <%= javascript_include_tag("/webpack/#{get_webpack_chunk('bundle', 'js')}") %> | ||
| <%= javascript_include_tag("/webpack/#{get_webpack_chunk('reactExports', 'js')}") %> | ||
| <%= javascript_include_tag("/webpack/#{get_webpack_chunk('bundle', 'js')}") %> |
| @@ -5,7 +5,8 @@ | |||
| "description": "Foreman isn't really a node module, these are just dependencies needed to build the webpack bundle. 'dependencies' are the asset libraries in use and 'devDependencies' are used for the build process.", | |||
| "private": true, | |||
| "engines": { | |||
| "node": ">=14.0.0 <21.0.0" | |||
| "node": ">=14.0.0 <21.0.0", | |||
| "npm": ">=8.0.0" | |||
| }, | |||
| "scripts": { | |||
There was a problem hiding this comment.
look into adding NODE_OPTIONS="--max-old-space-size=8192"
|
In this PR we had to update to npm 8 to get the "overrides" attribute in package.json - "Overrides provide a way to replace a package in your dependency tree with another version, or another package entirely. ". @theforeman/packaging are we ok to update to NPM 8+? |
MariaAga
force-pushed
the
remove-foreman-vendor
branch
from
2319c8b to
99923d6
Compare
MariaAga
force-pushed
the
remove-foreman-vendor
branch
from
d48bcac to
005f580
Compare
|
@theforeman/packaging are we ok to update to NPM 8+? |
There was a problem hiding this comment.
Not a real review, but I'd prefer to wrap up https://community.theforeman.org/t/drop-debian-11-ruby-2-7-and-nodejs-14-support-in-foreman-3-14/40503 first. Once we drop NodeJS 14 we should get NPM 8 or higher out of the box on all our supported platforms and that simplifies this PR.
Edit: for completeness, the NPM versions in packaging:
- EL9 with NodeJS 18: 10.2.4 (
dnf module enable nodejs:18 && dnf install npm) - Debian 12 with NodeJS 17: 9.2.0 (https://packages.debian.org/bookworm/npm)
- Ubuntu 22.04: TODO (OS repo has NodeJS 12 so we use nodesource; 14 at the moment)
When we merge #10406 it should be something we get for free. |
Depends on #10345 #10239