Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37949 - Fix typo #10360

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

nadjaheitmann
Copy link
Contributor

Was digging in some old code and randomly bumped into this.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically we don't use Refs (or Fixes) on already closed issues. I'd prefer to use a new issue. You can then in Redmine link them up.

On a related note: I've started to use the Fixes: trailer convention that the Linux kernel has adopted as well: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes. You can argue it's confusing to use fixes in 2 different ways and feel free to ignore it.

@nadjaheitmann nadjaheitmann changed the title Refs #7096 - Fix typo Fixes #37949 - Fix typo Oct 25, 2024
@nadjaheitmann
Copy link
Contributor Author

Typically we don't use Refs (or Fixes) on already closed issues. I'd prefer to use a new issue. You can then in Redmine link them up.

On a related note: I've started to use the Fixes: trailer convention that the Linux kernel has adopted as well: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes. You can argue it's confusing to use fixes in 2 different ways and feel free to ignore it.

Opened a new Redmine issue. I prefer to stay at "Fixes" for now as long as we don't make the "Fixes:" a new convention for Foreman projects :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants