Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38001 - Basic test for table sortings #10373

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MariaAga
Copy link
Member

Relies on: #10368 as without it the test will fail with:

#<ActionController::RoutingError: No route matches [GET] "/favicon.ico">
[MinitestRetry] retry 'test_0001_index page' count: 3,  msg: ActiveModel::UnknownAttributeError: unknown attribute 'locked' for Class.
    app/controllers/roles_controller.rb:25:in `index'

Tests that clicking on the sort in react and rb tables in index pages doesnt break the page, and also that the tables appears sorted.
Does not test that the sorting work as some tables have different ways of sorting so the search query wont always be order_by=some_header

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get #10368 first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants