Fixes #36525 - kickstart's RHSM line only works on RHEL hosts #9745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #36525 |
ekohl
reviewed
Jun 26, 2023
There was a problem hiding this comment.
I think rhinstaller/anaconda#2546 was a mistake and should be reverted. That would remove the need for this.
Also linking back https://community.theforeman.org/t/el9-kickstart-using-rhsm/32666 here.
app/views/unattended/provisioning_templates/provision/kickstart_default.erb
Outdated
Show resolved
Hide resolved
|
Linking in https://bugzilla.redhat.com/show_bug.cgi?id=2211944 The initial driver for the anaconda patch is 99.9% of rebuild users don't use self managed katello so presenting them with the subscription-manager gui is a confusing experience. Rebuilds and CentOS Stream shouldn't have a UI box for setting up subscriptions to RHN. The problem being, for folks with katello having access to subscription manager is useful. |
ekohl
previously approved these changes
Jul 4, 2023
|
rebased off HEAD to try and get the tests to run better... |
|
Test failures look relevant. I've opened #9769 to show how I think we could also make the tests pass, rather than adjust the fixtures. Feel free to consider both options and see what works best for you. I think the advantage of mine is that the rendered template is easier to review. |
|
I should have noted that I didn't test my PR and I can now see it fails in various ways. Will you address the failures or should I? |
|
I'm juggleing a few things today. Odds are I wont get back to this for a week or two... If you've got the time, I think you've got write access to my branch. |
|
I finally found time to get back to this, |
|
It would be super helpful if the tests indicated which template from the list it doesn't like... I've never succeeded in generating the template snapshots locally... |
stejskalleos
requested changes
Jul 27, 2023
There was a problem hiding this comment.
With this PR rendering the kickstart_default template on the CentOS host is failing on:
There was an error rendering the Kickstart default template: ERF42-7327 [Foreman::Exception]: The snippet 'redhat_register' threw an error: Safemode doesn't allow to access 'registration_type' on #<Safemode::ScopeObject>
|
Indeed it is. It seems an odd error since I didn't add the Since I don't think I broke it, I'm not sure how to fix it... |
|
@stejskalleos Any ideas how I can get this to work with |
stejskalleos
requested changes
Aug 29, 2023
app/views/unattended/provisioning_templates/provision/kickstart_default.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/snippet/redhat_register.erb
Outdated
Show resolved
Hide resolved
stejskalleos
requested changes
Aug 30, 2023
|
hmmmmm |
|
In theory I've sorted out the merge conflicts. |
pr-processor
bot
added
Waiting on contributor
and removed
Waiting on contributor
labels
|
I'd love to have this in place for foreman 3.10... |
|
@stejskalleos any luck with the templates? |
|
Generating snapshots is broken right now, reopening PR which fix the problem: https://github.com/theforeman/foreman/pull/9530/files |
|
@jcpunk with latest foreman develop branch generating snapshots works for me with the following command: May I ask you to rebase and try again? |
|
Still no luck: |
|
No clue why it still won't work for you. But, I think the remaining test-error is 'valid', because for the failing test-case (RHEL9) it should add the If |
|
I've just now added an I don't know why the factory uses I feel like somewhere in there should be a template that runs the subscription-manager snippet on CentOS Stream9 or the AltLinux distro from the tests, but I don't know how to add/generate that. |
|
Tests are green 👍 |
|
I am worried that there isn't an explicit test for non-RHEL systems >9.0 |
|
|
Changes LGTM, I'll ping our QAs for final verification |
ShimShtein
requested changes
Apr 10, 2024
app/views/unattended/provisioning_templates/provision/kickstart_default.erb
Outdated
Show resolved
Hide resolved
ShimShtein
reviewed
Apr 11, 2024
app/views/unattended/provisioning_templates/provision/kickstart_default.erb
Outdated
Show resolved
Hide resolved
pr-processor
bot
added
Waiting on contributor
and removed
Waiting on contributor
labels
ShimShtein
previously approved these changes
Apr 14, 2024
|
Hi, #10121 has been merged, so if you rebase over latest develop and run the |
|
Rebased, I may have sorted the snippets out |
|
[test integration] |
stejskalleos
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
🍏
Everything is green, and the snapshots are OK. Let's get this in.
Thanks @jcpunk and everyone for the help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch gets my self managed katello working again with foreman kickstarts.