-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move rubocop into foreman.yml #9924
Conversation
430834a
to
ce2242d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on combining RuboCop with matrix building?
ruby-version: 2.7 | ||
bundler-cache: true | ||
- name: Run rubocop | ||
run: bundle exec rubocop -P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When rubocop is >= 1.2 you can use --format github
to get GH annotations, but we'd need to update theforeman-rubocop from 0.0.6 to 0.1.x. We should add that to the list of updates to perform: theforeman/theforeman-rubocop#8 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, updating tfm-r would be good.
You mean "in the same step"? I'd leave it separated for visibility reasons. |
If you separate it out, would it make sense to reuse https://github.com/theforeman/actions/blob/v0/.github/workflows/rubocop.yml? And perhaps also run it after matrix building. So it's
Then in rubocop you can use |
Does the Ruby version we run Rubocop with really matter (as long it's a compatible one)? |
Not a lot. The reuse of the matrix is more important than the exact order. Newest for RuboCop is IMHO preferred, but not required. |
ce2242d
to
bd28594
Compare
There you go. I briefly considered to run Rubocop for all rubies (like, you know, with a real matrix), but then could not find a good reason to do so. |
No description provided.