move rubocop into foreman.yml

[evgeni]

No description provided.

[ekohl]

Any thoughts on combining RuboCop with matrix building?

[ekohl]

When rubocop is >= 1.2 you can use --format github to get GH annotations, but we'd need to update theforeman-rubocop from 0.0.6 to 0.1.x. We should add that to the list of updates to perform: theforeman/theforeman-rubocop#8 (comment)

[evgeni]

Yeah, updating tfm-r would be good.

[evgeni]

Any thoughts on combining RuboCop with matrix building?

You mean "in the same step"? I'd leave it separated for visibility reasons.

[ekohl]

If you separate it out, would it make sense to reuse https://github.com/theforeman/actions/blob/v0/.github/workflows/rubocop.yml? And perhaps also run it after matrix building. So it's

• setup_matrix
• rubocop
• tests
• dummy

Then in rubocop you can use matrix.ruby[0] to get the Ruby version. If so, we should adopt the policy to always list the newest Ruby version first.

[evgeni]

Does the Ruby version we run Rubocop with really matter (as long it's a compatible one)?
(Remembering to keep the Rubies sorted will be hard, but I think it just doesn't matter which one we pick)

[ekohl]

Not a lot. The reuse of the matrix is more important than the exact order. Newest for RuboCop is IMHO preferred, but not required.

[evgeni]

There you go.

I briefly considered to run Rubocop for all rubies (like, you know, with a real matrix), but then could not find a good reason to do so.