Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37429 - Update theforeman-rubocop to v0.1.2 #9926

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

@ekohl
Copy link
Member

ekohl commented Nov 29, 2023

I would start with fixing up the minitest cops and submit those as a PR. That will trim this down, but also work in develop.

@archanaserver
Copy link
Contributor Author

@ekohl I was trying to run bundler but throwing this error, I can't continue because I can't understand why it is talking about foreman-admin dir here even though i'm in the right one? Would you mind taking a look here?


[!] There was an error parsing `Gemfile`: There are no gemspecs at /home/akumari/Desktop/foreman-admin. Bundler cannot continue.

 #  from /home/akumari/Desktop/foreman/Gemfile:56
 #  -------------------------------------------
 #  Dir["#{File.dirname(FOREMAN_GEMFILE)}/bundler.d/*.rb"].each do |bundle|
 >    instance_eval(Bundler.read_file(bundle))
 #  end
 #  -------------------------------------------

@archanaserver archanaserver marked this pull request as ready for review December 21, 2023 09:58
@ekohl
Copy link
Member

ekohl commented Dec 21, 2023

Check if there's anything in your local bundler files: grep foreman-admin bundler.d/*

@archanaserver
Copy link
Contributor Author

Check if there's anything in your local bundler files: grep foreman-admin bundler.d/*

Got it, Thanks!

also @ekohl, how can we handle this Rubocop failed offenses, i can see this is a lot.

@ekohl
Copy link
Member

ekohl commented Jan 3, 2024

also @ekohl, how can we handle this Rubocop failed offenses, i can see this is a lot.

In my experience it's best to look at them one by one. RuboCop has --only to do that. Then there are also cops which change a lot of code, like Layout. So I'd first focus on Minitest/*

@stejskalleos
Copy link
Contributor

@archanaserver can you please rebase over the latest develop?

@archanaserver
Copy link
Contributor Author

@stejskalleos Now this need a long list of RuboCop fix, I have raised PR for Minitest/ and Layout/:

I posted something related to my Layout/ArgumentAlignment cops fixes issue I'm facing, https://community.theforeman.org/t/rubocop-changes-in-foreman-input-needed/36950

@archanaserver archanaserver changed the title update theforeman-rubocop gem Fixes #37429 - update theforeman-rubocop gem May 9, 2024
@archanaserver archanaserver force-pushed the update-theforeman-rubocop branch 2 times, most recently from 29048ec to fa21411 Compare August 1, 2024 07:25
@archanaserver
Copy link
Contributor Author

@ehelms i have rebased PRs, do you mind looking on those PRs? I'm tracking it here #9926 (comment)

@archanaserver archanaserver changed the title Fixes #37429 - update theforeman-rubocop gem Fixes #37429 - Update theforeman-rubocop to v0.1.2 Oct 22, 2024
@ehelms
Copy link
Member

ehelms commented Oct 25, 2024

I think this PR is stuck until Katello/katello#11009 (comment) is addressed

@archanaserver
Copy link
Contributor Author

I think this PR is stuck until Katello/katello#11009 (comment) is addressed

Made some changes there, Katello/katello#11009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants