Fixes #36947 - Broken openSUSE Leap 15 provisioning #9927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananace
force-pushed
the
opensuse-leap-15
branch
2 times, most recently
from
19aa152
to
84efe79
Compare
sbernhard
reviewed
Dec 8, 2023
app/views/unattended/provisioning_templates/provision/autoyast_default.erb
Outdated
Show resolved
Hide resolved
sbernhard
reviewed
Dec 8, 2023
|
Tested the templates as they are in the PR at the moment and they work fine. |
evgeni
reviewed
Mar 1, 2024
app/views/unattended/provisioning_templates/provision/autoyast_default.erb
Outdated
Show resolved
Hide resolved
ekohl
reviewed
Mar 1, 2024
app/views/unattended/provisioning_templates/provision/autoyast_default.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/provision/autoyast_default.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/provision/autoyast_default.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/provision/autoyast_default.erb
Outdated
Show resolved
Hide resolved
ananace
force-pushed
the
opensuse-leap-15
branch
2 times, most recently
from
279e203
to
490f999
Compare
|
Found some time to do a few test installs, so it should be good in terms of review comments now. Also disabled the resolv.conf copy step on Leap 15, since it has them both as symlinks to the same runtime file anyway, which just causes the installer to warn and sleep for five seconds. |
sbernhard
reviewed
Apr 15, 2024
app/views/unattended/provisioning_templates/provision/autoyast_default.erb
Outdated
Show resolved
Hide resolved
ananace
force-pushed
the
opensuse-leap-15
branch
from
490f999
to
287de73
Compare
ananace
force-pushed
the
opensuse-leap-15
branch
from
287de73
to
5a5c9b4
Compare
|
Just realized that the OS specifier in the templates has been wrong the entire time, so the template sync wouldn't associate them, that's now fixed as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Puppet uses a mix of keys which are not all retrievable properly using the regular AutoYaST template, so this will directly import them from the RPM repo instead.
Puppet AIO packages also work on openSUSE, so this removes the limitation on SLES to allow proper Puppet installs to work.
Also cleans up the iPXE template and ensures BOOTIF is provided, so that boot works properly on multi-NIC devices.