-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #36716 - Add check for missing product-content #757
base: master
Are you sure you want to change the base?
Fix #36716 - Add check for missing product-content #757
Conversation
fc6e357
to
718e497
Compare
718e497
to
a561f25
Compare
a561f25
to
e6fb497
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally not a fan of SQL in a tool. Could the same information be retrieved from Candlepin using the official API? If so, could Katello do so and implement it as a rake command?
I'm mostly worried about Candlepin version updates which changes the DB somehow and verifying this part can easily be forgotten.
We don't have a good group to ping, but @ianballou may know or may know who can make it happen.
I agree with @ekohl that this is a little strange to have in foreman-maintain. It would be really perfect to have it exist as a rake script in Katello. However, this script does look like it would be incredibly helpful to have around for when users have issues with repositories not appearing in their It looks like you can get product content from products at least via the Candlepin API:
If rewriting with the Candlepin API ends up being too much to prioritize, I'd be for keeping it as-is |
@ianballou @ekohl , I created a rake-task, which does similar things: Katello/katello#10740 At the moment I do not have a system that really has the issue this is intended to fix. |
source https://github.com/ATIX-AG/orcharhino-scripts/tree/main/find_missing_candlepin_product_contents