Update packages update #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Proposing two changes here that are related:
These two changes come from https://bugzilla.redhat.com/show_bug.cgi?id=2042899#c9 |
evgeni
reviewed
Apr 11, 2024
evgeni
reviewed
Apr 11, 2024
|
I'm cool with the changes (minus the few style comments I had) and you offended the 👮♂️ |
|
Yea, for some reason Rubocop is throwing errors that are not showing up locally and it's really confusing. |
ehelms
force-pushed
the
update-packages-update
branch
from
91268ff
to
0bfd9f4
Compare
ehelms
force-pushed
the
update-packages-update
branch
from
0bfd9f4
to
1c01eef
Compare
evgeni
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.