-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37357 - Add container migration to upgrade #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you address the rubocop issues please?
1ad344c
to
2eee300
Compare
This is not needed on content proxies? Just the main server? |
2eee300
to
9317a24
Compare
It is..Added to proxy upgrade.. Do the same scenarios run for upstream upgrades as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to note that we'll also need to add the indexing task to this afterwards.
5d718c7
to
b37dc32
Compare
Will get to the merge conflict. Does the change look good @ehelms ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave this a test with a mock Satellite upgrade, the command is indeed called right before the last step, and I saw the correct message, so I think it's all good.
b37dc32
to
99ea5bb
Compare
@sjha4 I will get to checking this early this week. |
99ea5bb
to
1d1d5c2
Compare
Adding container-handle-image-data migration to post-upgrade tasks with upgraded pulp.