Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make backup scenario more readable #857

Merged
merged 2 commits into from
May 29, 2024
Merged

make backup scenario more readable #857

merged 2 commits into from
May 29, 2024

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented May 29, 2024

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to remove the online_backup? helper as well. The other code implies there could be more strategies (since it's a case statement), which could imply that !online_backup? isn't always equal to strategy == :offline.

definitions/scenarios/backup.rb Outdated Show resolved Hide resolved
@evgeni
Copy link
Member Author

evgeni commented May 29, 2024

I'd be tempted to remove the online_backup? helper as well. The other code implies there could be more strategies (since it's a case statement), which could imply that !online_backup? isn't always equal to strategy == :offline.

Well, there used to be, but I really would like to only have as few as possible.

Done

@evgeni evgeni merged commit 27ae735 into master May 29, 2024
8 checks passed
@evgeni evgeni deleted the decompose-backup branch May 29, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants