Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix self-upgrade by adding enabled-repos support to dnf #859

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented May 31, 2024

No description provided.

@evgeni
Copy link
Member

evgeni commented Jun 4, 2024

While I like the refactoring, I do not understand what this is fixing.

Previously, self upgrade would self (lol) calculate the needed DNF options for --enablerepo, now the handling has been moved to the DNF helper itself, which is nice but should result in the very same dnf invocation?

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be cool if the commit message would refer to the commit that broke it ;)

@ehelms ehelms merged commit 29abb20 into theforeman:master Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants