-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refresh collation version when pulp_ansible is installed #863
Conversation
39742ab
to
a93f9d6
Compare
testing via:
needs theforeman/forklift#1823 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a reference on why this is needed?
execute!('runuser -c '\ | ||
'\'echo "ALTER COLLATION pulp_ansible_semver REFRESH VERSION;"'\ | ||
'| psql pulpcore\' postgres') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed for remote DBs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not when they don't switch the OS :)
pulp_ansible ships an "own" collation since pulp/pulp_ansible@d442dde, which requires a "refresh" of the version (after the reindex) if the underlying collation library (icu) changes, which happens during 8to9. otherwise you get "WARNING: collation "pulp_ansible_semver" has version mismatch" in the postgres logs:
we do the same in leapp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why a custom collation is needed, but given it's used I think this is correct.
No description provided.