Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't run restorecon before restoring a backup #873

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jun 5, 2024

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added in 1ae71c3, but I have a hard time thinking of why this would be needed.

Perhaps this has to do with parent directories where children can inherit incorrect labels?

@evgeni
Copy link
Member Author

evgeni commented Jun 5, 2024

This was added in 1ae71c3, but I have a hard time thinking of why this would be needed.

Perhaps this has to do with parent directories where children can inherit incorrect labels?

Not quite. It was added in Katello/katello-packaging@f5a8663 (note: I had to jump from foreman_maintain.git to foreman-packaging.git to katello-packaging.git to even find this, 💀 -- actually, even worse, it starts in Katello/katello#5183)

I'd still assume it's not needed, but oh well.

I mean, we run on a working Foreman/Katello, why would you need to relabel things.

@evgeni
Copy link
Member Author

evgeni commented Jun 5, 2024

my basic test (ansible-playbook pipelines/clone_pipeline.yml -e pipeline_os=centos9-stream -e pipeline_type=clone -e pipeline_version=nightly -e '{"packit_prs":["theforeman/foreman_maintain/873"]}') passed, so I call this OK :)

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was after restoring, I'd be a lot more understanding. Let's try this.

@evgeni evgeni merged commit f6a4160 into master Jun 5, 2024
8 checks passed
@evgeni evgeni deleted the no-selinux branch June 5, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants