Ensure only certificates are included when parsing for sha1 check. #971
+55
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
reviewed
Jan 6, 2025
ehelms
force-pushed
the
empty-line-ca-sha1
branch
2 times, most recently
from
a125a5e to
5b3a4ab
Compare
ehelms
changed the title
ehelms
force-pushed
the
empty-line-ca-sha1
branch
from
5b3a4ab to
3733b11
Compare
|
Updated to include a fix, some test updates and more output. |
evgeni
reviewed
Jan 8, 2025
| return unless server_ca | ||
| return true if server_ca.nil? |
evgeni
reviewed
Jan 8, 2025
evgeni
reviewed
Jan 8, 2025
test/definitions/checks/check_sha1_certificate_authority_test.rb
Outdated
Show resolved
Hide resolved
evgeni
approved these changes
Jan 8, 2025
Signed-off-by: Eric D. Helms <[email protected]>
ehelms
force-pushed
the
empty-line-ca-sha1
branch
from
baa906f to
0a220c7
Compare
evgeni
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.