-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix "SCAP Content" menu entry #420
base: master
Are you sure you want to change the base?
Conversation
* Converts the "SCAP Content" menu entry to title case. * Converts the uncountable noun "Content" to singular.
Can one of the admins verify this patch? |
The reason it is "WIP" is that converting the term "Content" to singular means that certain paths and variables should also be changed. This is more involved and needs more testing, that I have not yet gotten around to... |
Thanks for the patch, while we're on topic, what do you think about extracting the whole menu to first level category? |
Does "first level category" mean that Open SCAP would have its own menu next to "Monitor", "Content", "Hosts", "Configure", etc. ? |
Perhaps we should really open a discussion on discourse. I feel like my previous comment goes beyond the scope of a PR. 😄 |
@quba42 Hi, sorry for doing a bit of a repo archeology and poking into old things, but was there such a discussion? |
@adamruzicka If I did not link such a discussion here, then no, it probably did not happen. |
Relates to: https://projects.theforeman.org/issues/25223