Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37673 - Refactor deprecated jquery functions #576

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

MariaAga
Copy link
Member

Draft since Cookies has not been added to tfm yet (theforeman/foreman#10250)

@adamruzicka
Copy link
Contributor

This will eventually need to bump minimal foreman version in engine.rb to 3.14.

@adamruzicka
Copy link
Contributor

The required foreman pr was merged

@MariaAga
Copy link
Member Author

Thanks, updated.
Tested in /compliance/arf_reports -> selecting a few and clicking on delete reports and seeing the selected ones are shown

@MariaAga MariaAga marked this pull request as ready for review November 26, 2024 14:11
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MariaAga, LGTM and seems to be working 🌹

@ofedoren ofedoren merged commit 507d29a into theforeman:master Dec 2, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants