SAT-28994 - Fix About subscription watch link on RH Cloud Inventory page #916
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ColeHiggins2 can you test this with packit? I can do a code review on it. |
chris1984
reviewed
Oct 28, 2024
There was a problem hiding this comment.
Looks like we need to update the JS snapshot here:
webpack/ForemanInventoryUpload/Components/PageHeader/components/PageDescription/__tests__/__snapshots__/PageDescription.test.js.snap: href="https://access.redhat.com/documentation/en-us/subscription_central/2020-04/html/getting_started_with_subscription_watch/assembly-about-subscriptionwatch
lfu
force-pushed
the
28994_about_subs_watch
branch
from
36c0be3 to
44fd32c
Compare
chris1984
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Looks and works fine to me, waiting on @ColeHiggins2 to test it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test
The link should redirect to the document of Getting Started with the Subscriptions Service.