Fixes #919 - isNotRhelHost regex too restrictive #920
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris1984
reviewed
Oct 30, 2024
chris1984
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
ACK, works fine, thanks @Thorben-D I left one comment:
Ubuntu not showing the insights tab:
RHEL 8 showing the insights tab:
RHEL 9 showing the insights tab:
chris1984
reviewed
Nov 1, 2024
There was a problem hiding this comment.
@Thorben-D one comment and it should be good to go. Maria has some helpful content to get the JS test to pass.
Thorben-D
force-pushed
the
improve_insights_regex
branch
from
41806c3 to
a902fa1
Compare
- Changed regex to be more wide-ranging - Fixed a bug in InsightsTotalRiskChartWrapper where the wrong parameter was passed to isNotRhelHost
Thorben-D
force-pushed
the
improve_insights_regex
branch
from
a902fa1 to
42cbacb
Compare
|
@chris1984 Sorry, it was a public holiday and I just managed to check my mail this evening. |
|
@Thorben-D Awesome, thanks for the fix :) Will get it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the regex used in the
isNotRhelHostfunction, which was introduced in #911.The regex now accepts variations of RedHat, RHEL and RHCOS as valid.
Additionally, the wrong parameter was passed to the function in
InsightsTotalRiskChartWrapper.CC @chris1984