Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Test with Katello" #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parthaa
Copy link

@parthaa parthaa commented Sep 11, 2024

This reverts commit b0ae4c6.

This prevents this error

[!] There was an error parsing `Gemfile`: You cannot specify the same gem twice coming from different sources.
You specified that katello (>= 0) should come from https://github.com/Katello/katello.git and source at `../katello`
. Bundler cannot continue.

 #  from /home/vagrant/foreman/Gemfile:59
 #  -------------------------------------------
 #    puts "looking at '#{bundle}'"
 >    instance_eval(Bundler.read_file(bundle))
 #  end
 #  -------------------------------------------

This reverts commit b0ae4c6.
@chris1984
Copy link
Member

@ofedoren this reverts the katello bundle install error Partha posted. Do you have a suggestion to get the tests green again?

@ekohl
Copy link
Member

ekohl commented Sep 12, 2024

I think this is tricky. We need this for CI and I don't see any other way. But then theforeman/puppet-katello_devel@6d42c4c combines all the different gemfile.d entries and that creates a conflict.

@ofedoren
Copy link
Member

Do you have a suggestion to get the tests green again?

Either have this commit or release Katello with Zeitwerk changes, not sure if there is another way...

@ekohl
Copy link
Member

ekohl commented Sep 12, 2024

Perhaps one option is to change this into a group:

group :foreman_virt_who_configure_deps do
  gem 'katello', github: 'Katello/katello', branch: 'master'
end

Then you might be able to use bundle config without foreman_virt_who_configure_deps to skip it, but I recall Bundler always evaluates all dependencies so it may not work.

Another ugly option is to hide it behind some ENV var, which is also ugly but perhaps less so.

@ekohl
Copy link
Member

ekohl commented Sep 13, 2024

I opened #202 which can work, but has some caveats.

@ehelms
Copy link
Member

ehelms commented Sep 19, 2024

I propose we do not revert the change but instead change how we handle the devel environment -- theforeman/puppet-katello_devel#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants