add test for container push on Katello 4.14+ #1853
Conversation
| CONTAINER_PULL_LABEL=$(echo "${ORGANIZATION_LABEL}-${PRODUCT_LABEL}-${CONTAINER_REPOSITORY_LABEL}"| tr '[:upper:]' '[:lower:]') | ||
| CONTAINER_PUSH_LABEL=$(echo "${ORGANIZATION_LABEL}/${PRODUCT_LABEL}/${CONTAINER_REPOSITORY_LABEL}-bats-$(date -u '+%s')"| tr '[:upper:]' '[:lower:]') |
There was a problem hiding this comment.
Yes, you need to pull with ORG-PRODUCT-REPO but push with ORG/PRODUCT/REPO.
@ianballou this hurts 😿
There was a problem hiding this comment.
Aye it does - @ianballou is looking into whether we could switch to a / based naming scheme which is more common within the container world.
There was a problem hiding this comment.
interestingly, pushed stuff is then also only pull-able with / -- so - only applies to synced stuff? confusing!
There was a problem hiding this comment.
Exactly, we wanted content to be pullable with the same path that you pushed to. The way synced content gets distributed is out of date and confusing for sure.
There was a problem hiding this comment.
Synced content follows a naming scheme that the user can set on a per-environment basis. I guess in the early container days you couldn't have slashes, because dashes were chosen for some reason for the default.
Jump forward to now with container push, if we kept the environmental naming pattern, then users would see names change after they push, which is bad. So, for push, the naming scheme set on environments is ignored.
Now all that's left is the correct the old pattern for synced repositories.
There was a problem hiding this comment.
I will add -- if you want all slashes before we fix it, BATS could change the container naming scheme :)
There was a problem hiding this comment.
nah, let's keep as close to the default config as possible
bats/foreman_helper.bash
Outdated
| @@ -53,6 +53,13 @@ tSkipIfNewerThan45() { | |||
| fi | |||
| } | |||
|
|
|||
| tContainerPushSupported() { | |||
| KATELLO_VERSION=$(tKatelloVersion) | |||
| if ! tIsVersionNewer "${KATELLO_VERSION}" 4.13; then | |||
There was a problem hiding this comment.
That's based on Katello/katello#10952 -- is that a correct assumption?
There was a problem hiding this comment.
That PR is just the beginning, I need to check but I think 4.14 would be better.
There was a problem hiding this comment.
@evgeni I confirmed that Katello 4.14 and higher should be used here.
evgeni
force-pushed
the
container-push
branch
from
a45c656
to
b3c1a67
Compare
I did run it once on nightly and it didn't totally freak out, yeah :) |
ianballou
dismissed
their stale review
Saw it was only tested on nightly, oops
bats/foreman_helper.bash
Outdated
| @@ -53,6 +53,13 @@ tSkipIfNewerThan45() { | |||
| fi | |||
| } | |||
|
|
|||
| tContainerPushSupported() { | |||
| KATELLO_VERSION=$(tKatelloVersion) | |||
| if ! tIsVersionNewer "${KATELLO_VERSION}" 4.13; then | |||
There was a problem hiding this comment.
@evgeni I confirmed that Katello 4.14 and higher should be used here.
evgeni
force-pushed
the
container-push
branch
from
b3c1a67
to
9a7fd65
Compare
evgeni
changed the title
No description provided.