Become root in foreman_proxy_content role to add group

[ianballou]

Fixes an error when provisioning a proxy content devel box where the vagrant user was trying to add the foreman group.

[chris1984]

PR worked fine for me to get me going with a proxy box. @ehelms can you do a review on this?

[sjha4]

Fixed the below error:

TASK [foreman_proxy_content : Generate Certs] **********************************
fatal: [centos9-proxy-devel2 -> centos9-katello-devel(None)]: FAILED! => changed=true 
  cmd:
  - foreman-proxy-certs-generate
  - --foreman-proxy-fqdn
  - centos9-proxy-devel2.sajha.example.com
  - --certs-tar
  - /root/centos9-proxy-devel2.sajha.example.com.tar.gz
  delta: '0:00:00.337804'
  end: '2024-10-25 20:47:43.688736'
  msg: non-zero return code
  rc: 1
  start: '2024-10-25 20:47:43.350932'
  stderr: |-
    /usr/share/ruby/psych.rb:582:in `initialize': Permission denied @ rb_sysopen - /usr/share/foreman-installer/katello-certs/scenarios.d/foreman-proxy-certs.yaml (Errno::EACCES)
            from /usr/share/ruby/psych.rb:582:in `open'
            from /usr/share/ruby/psych.rb:582:in `unsafe_load_file'
            from /usr/share/gems/gems/kafo-7.5.1/lib/kafo/scenario_manager.rb:21:in `block in available_scenarios'
            from /usr/share/gems/gems/kafo-7.5.1/lib/kafo/scenario_manager.rb:19:in `each'
            from /usr/share/gems/gems/kafo-7.5.1/lib/kafo/scenario_manager.rb:19:in `inject'
            from /usr/share/gems/gems/kafo-7.5.1/lib/kafo/scenario_manager.rb:19:in `available_scenarios'
            from /usr/share/gems/gems/kafo-7.5.1/lib/kafo/scenario_manager.rb:100:in `select_scenario'
            from /usr/share/gems/gems/kafo-7.5.1/lib/kafo/kafo_configure.rb:575:in `config_file'
            from /usr/share/gems/gems/kafo-7.5.1/lib/kafo/kafo_configure.rb:115:in `initialize'
            from /usr/share/gems/gems/clamp-1.3.2/lib/clamp/command.rb:140:in `new'
            from /usr/share/gems/gems/clamp-1.3.2/lib/clamp/command.rb:140:in `run'
            from /usr/share/gems/gems/kafo-7.5.1/lib/kafo/kafo_configure.rb:54:in `run'
            from /usr/sbin/foreman-proxy-certs-generate:54:in `<main>'
  stderr_lines: <omitted>
  stdout: ''
  stdout_lines: <omitted>

[ekohl]

I wonder if the whole role itself should declare become properly but I'm ok with this improvement now

[evgeni]

I wonder if the whole role itself should declare become properly but I'm ok with this improvement now

Wouldn't that revert #1840

[ianballou]

Thanks all!

[ekohl]

Wouldn't that revert #1840

What I meant was that we could sprinkle become: true in roles/foreman_proxy_content/tasks where needed to avoid needing to do it on the playbook level.

Looking at it, the current PR effectively reverts that, right? Now every role is called with become: true which I'd think is the same as calling it on the playbook level.

[evgeni]

It's not the same, no
Setup is still running as a user, and I think that's what was intended

[ekohl]

Ah ok, that's something about Ansible I didn't know.